Treat explicit imports from node_modules as external library imports#16364
Merged
4 commits merged intoAug 17, 2017
Merged
Conversation
ghost
commented
Jun 8, 2017
| export interface ResolvedModule { | ||
| /** Path of the file the module was resolved to. */ | ||
| resolvedFileName: string; | ||
| /** |
Author
There was a problem hiding this comment.
This comment didn't describe what we're actually doing. We don't validate the contents of files in any way while doing module resolution.
ghost
requested a review
from 
Contributor
|
I'm not sure what the ramifications of turning everything in Specifically, what changes in our treatment of a module when it is an external library import vs. an import within the project? |
Contributor
|
Talked offline, LGTM |
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15970 and #15755